include: stm32: clock_control: Ease usage of STM32_DT_CLOCKS macro #46842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Required for #46703 |
gmarull
reviewed
Jun 23, 2022
erwango
force-pushed
the
fix_DT_STM32_clock_macro
branch
from
ddf1d71 to
6eb67db
Compare
erwango
requested review from
MaureenHelm,
carlescufi,
galak and
nashif
as code owners
gmarull
reviewed
Jun 23, 2022
gmarull
previously approved these changes
Jun 23, 2022
FRASTM
previously approved these changes
Jun 23, 2022
STM32_DT_CLOCKS was designed to take a device tree node label name as argument: STM32_DT_CLOCKS(uart1) Change its implementation to take a node identifier instead: STM32_DT_CLOCKS(DT_NODELABEL(uart1)). This make its usage more flexible since the argument can now be extracted from other DT macros such as DT_PARENT. Then, the following can be done: STM32_DT_CLOCKS(DT_PARENT(child_node_label)). Since it is now possible implement STM32_DT_INST_CLOCKS using STM32_DT_CLOCKS. Finally, update existing STM32_DT_CLOCKS users and convert STM32_INST_CLOCK_INFO users to STM32_CLOCK_INFO. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
fix_DT_STM32_clock_macro
branch
from
6eb67db to
e32ed4e
Compare
FRASTM
approved these changes
Jun 27, 2022
Member
Author
|
@gmarull I had to update this PR. Can you review again ? |
gmarull
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STM32_DT_CLOCKS was designed to take a device tree node label name as
argument: STM32_DT_CLOCKS(uart1)
Change its implementation to take a node identifier instead:
STM32_DT_CLOCKS(DT_NODELABEL(uart1)).
This make its usage more flexible since the argument can now be extracted
from other DT macros such as DT_PARENT. Then, the following can be done:
STM32_DT_CLOCKS(DT_PARENT(child_node_label)).
Signed-off-by: Erwan Gouriou [email protected]